atomist-attic / rug

DEPRECATED Runtime for Rugs
GNU General Public License v3.0
53 stars 13 forks source link

Cleanup some old rug stuff - fix a few little bugs #589

Closed kipz closed 7 years ago

kipz commented 7 years ago

Don't be daunted by the number of files change - most are just automated changes to test files etc.

Changed

Fixed

kipz commented 7 years ago

I'm torn on whether removing the old interfaces is good or not. On the one hand I like deleting code. On the other hand, we keep saying we need to stop breaking our public interfaces.

Indeed me too, but we can be pretty sure that they are not used - this would not be deliberately breaking users. And given we've recently shampooed all the rugs, I'd be very surprised if anything broke.

jessitron commented 7 years ago

+1 overall although it'd be really nice if there were multiple commits distinguishing interface changes from test updates ;-)