Node support is needed for the smoke test nodeBuild.feature and it seems like a regression that node projects are no longer built with the addivie machine. There is likely more node support that is missing. For deployment for example.
I noticed that addBuildRules is now deprecated, but I don't know what else to use, and it is still used when configuring the machine.
build.setDefault for the MavenBuilder was moved to the end because order seems to matter here. If it is set first, then it will always execute because of the overly permissive AnyPush test that default is automatically given. It resulted in the node build rules that I added never firing. This seems like a flaw with setDefault or the goal implementation mapper. These defaults need to be ordered at the end of the implementations or be handled differently than the when implementations. This seems like a gotcha that would make build rule firing unnecessarily confusing.
added a generator for a buildable node seed that could be used in the smoke test that will actually build and fail. The minimal-node-seed doesn't actually build and will never fail.
Node support is needed for the smoke test nodeBuild.feature and it seems like a regression that node projects are no longer built with the addivie machine. There is likely more node support that is missing. For deployment for example.
I noticed that addBuildRules is now deprecated, but I don't know what else to use, and it is still used when configuring the machine.
build.setDefault for the MavenBuilder was moved to the end because order seems to matter here. If it is set first, then it will always execute because of the overly permissive AnyPush test that default is automatically given. It resulted in the node build rules that I added never firing. This seems like a flaw with setDefault or the goal implementation mapper. These defaults need to be ordered at the end of the implementations or be handled differently than the when implementations. This seems like a gotcha that would make build rule firing unnecessarily confusing.
added a generator for a buildable node seed that could be used in the smoke test that will actually build and fail. The minimal-node-seed doesn't actually build and will never fail.