search

atomist-skills / github-notifications-skill

Atomist Skill to surface GitHub activity in Chat, eg Slack or Microsoft Teams
Apache License 2.0
0 stars 0 forks source link

Simplify adding custom emoji #28

Closed jrday closed 4 years ago

jrday commented 4 years ago

It looks like there is only an API for adding emoji in Enterprise Grid but can we run the atomist-emojis.bash script as the bot user, or is that not something a bot/app can do?

/cc @slimslenderslacks

slimslenderslacks commented 4 years ago

@jrday the last we checked, this required the admin.teams:write scope, and our app does not request that. Most users that authorize Atomist will have the permission to add custom emojis on their team (I think most non-guest users can add emojis by default), so it's really just about the scoping. As is often the case, this scope is quite broad and would grant our app access to other apis (like setName setIcon setDefaultChannel) that we'd prefer our app not be able to access. The achilles heal of OAuth, isn't it?

So, I think we could probably run this, but we'd have to extend our OAuth scopes. It would be worth testing with our staging app.

atomist[bot] commented 4 years ago

Thanks for your contribution!

This issue has been automatically marked with stale because it has not had any activity in last 50 days. It will be closed in 7 days if no further activity occurs. To prevent closing, label with defer or blocked or any of the changelog: labels.