search

atomist-skills / string-replace-skill

Atomist Skill to run a regex replace editor across a codebase
Other
0 stars 0 forks source link

Git commit error #38

Closed cdupuis closed 4 years ago

cdupuis commented 4 years ago

https://go.atomist.com/log/T7GMF5USG/bca264f2-ee05-47db-9833-0d43e0714a93/W9VOVrylo8ixV0GEN8mRJ?name=string-replace-skill&namespace=atomist

2020-05-02 01:36:49.226 ERROR: promise error:  Error: Child process 36 exited with non-zero status 1: /tmp/atm-1-1CZNMvEIPSIlY ==> git 'commit' '-m' 'Ran string replacement s/([a-zA-Z]*?)_([a-zA-Z])/$1\U$2/g on *.{yaml,yml}
[atomist:edited]'
cdupuis commented 4 years ago

I think that git commit failed because there were no actual changes to commit. Probably that log statement was just confusing for me to see as I thought something failed because I was expecting changes to be committed based on the repo I pushed to.

slimslenderslacks commented 4 years ago

Yes, there were no changes on the commit. But the more important point is what lead you to think that something should have happened here I guess.

cdupuis commented 4 years ago

I used the pattern *.{yml,yaml} which should have matched a couple of files but apparently it didn’t.

slimslenderslacks commented 4 years ago

Have migrated to fast-glob - will push this out