Closed cdupuis closed 5 years ago
app/components/codeSubmission/codeDisplay.tsx:27
app/components/codeSubmission/codeDisplay.tsx:60
app/components/codeSubmission/codeDisplay.tsx:105
app/components/codeSubmission/highlightCode.ts:25
app/components/codeSubmission/highlightCode.ts:34
app/components/codeSubmission/highlightCode.ts:38
app/components/codeSubmission/highlightCode.ts:42
app/components/codeSubmission/ParserInput.tsx:40
app/components/codeSubmission/ParserInput.tsx:54
app/components/jsonDisplay/tree.tsx:21
app/components/jsonDisplay/TreeChoice.tsx:73
app/components/TreeParseGUI.tsx:41
app/components/TreeParseGUI.tsx:42
app/components/TreeParseGUI.tsx:68
app/components/TreeParseGUI.tsx:73
app/TreeParseGUIState.ts:4
app/components/codeSubmission/codeDisplay.tsx:21
app/components/codeSubmission/codeDisplay.tsx:75
app/components/codeSubmission/codeDisplay.tsx:78
app/components/codeSubmission/codeDisplay.tsx:82
app/components/codeSubmission/codeDisplay.tsx:86
app/components/codeSubmission/codeDisplay.tsx:91
app/components/codeSubmission/highlightCode.ts:20
app/components/codeSubmission/highlightCode.ts:51
app/components/codeSubmission/highlightCode.ts:52
app/components/codeSubmission/ParserInput.tsx:41
app/components/TalkOutLoud.tsx:9
app/components/TreeParseGUI.tsx:43
app/components/TreeParseGUI.tsx:44
app/components/TreeParseGUI.tsx:67
app/components/TreeParseGUI.tsx:81
app/components/TreeParseGUI.tsx:102
server.ts:24
server.ts:43
server.ts:63
server.ts:74
server.ts:79
app/components/codeSubmission/ParserInput.tsx:25
app/components/codeSubmission/ParserInput.tsx:29
app/components/TreeParseGUI.tsx:40
app/components/TreeParseGUI.tsx:69
app/TreeParseGUIState.ts:1
server.ts:9
server.ts:11
app/components/codeSubmission/codeDisplay.tsx:2
app/components/codeSubmission/codeDisplay.tsx:3
app/components/codeSubmission/codeDisplay.tsx:4
app/components/codeSubmission/codeDisplay.tsx:5
app/components/codeSubmission/codeDisplay.tsx:6
app/components/codeSubmission/codeDisplay.tsx:50
app/components/codeSubmission/codeDisplay.tsx:88
app/components/codeSubmission/codeDisplay.tsx:97
app/components/codeSubmission/highlightCode.ts:44
server.ts:23
app/components/codeSubmission/codeDisplay.tsx:19
app/components/codeSubmission/codeDisplay.tsx:32
app/components/codeSubmission/codeDisplay.tsx:38
app/components/codeSubmission/highlightCode.ts:15
app/components/codeSubmission/ParserInput.tsx:20
app/components/codeSubmission/ParserInput.tsx:28
app/components/codeSubmission/ParserInput.tsx:45
app/components/codeSubmission/ParserInput.tsx:57
app/components/ErrorDisplay.tsx:4
app/components/jsonDisplay/tree.tsx:6
app/components/jsonDisplay/tree.tsx:14
app/components/jsonDisplay/TreeChoice.tsx:12
app/components/jsonDisplay/TreeChoice.tsx:47
app/components/jsonDisplay/TreeChoice.tsx:69
app/components/jsonDisplay/TreeChoice.tsx:76
app/components/PathExpressionInput.tsx:4
app/components/TalkOutLoud.tsx:7
app/components/TreeParseGUI.tsx:19
app/components/TreeParseGUI.tsx:39
app/components/TreeParseGUI.tsx:51
app/components/TreeParseGUI.tsx:79
app/components/TreeParseGUI.tsx:84
app/components/TreeParseGUI.tsx:96
server.ts:104
[atomist:code-inspection:atomist/a260p86nh/typescript-version/master=@atomist/atomist-sdm]
Issue closed because branch atomist/a260p86nh/typescript-version/master was deleted.
atomist/a260p86nh/typescript-version/master
arrow-parens
app/components/codeSubmission/codeDisplay.tsx:27
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/codeDisplay.tsx:60
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/codeDisplay.tsx:105
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/highlightCode.ts:25
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/highlightCode.ts:34
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/highlightCode.ts:38
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/highlightCode.ts:42
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/ParserInput.tsx:40
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/codeSubmission/ParserInput.tsx:54
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/jsonDisplay/tree.tsx:21
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/jsonDisplay/TreeChoice.tsx:73
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/TreeParseGUI.tsx:41
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/TreeParseGUI.tsx:42
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/TreeParseGUI.tsx:68
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functionapp/components/TreeParseGUI.tsx:73
: (error) Parentheses are prohibited around the parameter in this single parameter arrow functioninterface-over-type-literal
app/TreeParseGUIState.ts:4
: (error) Use an interface instead of a type literal.no-console
app/components/codeSubmission/codeDisplay.tsx:21
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/codeDisplay.tsx:75
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/codeDisplay.tsx:78
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/codeDisplay.tsx:82
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/codeDisplay.tsx:86
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/codeDisplay.tsx:91
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/highlightCode.ts:20
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/highlightCode.ts:51
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/highlightCode.ts:52
: (warn) Calls to 'console.log' are not allowed.app/components/codeSubmission/ParserInput.tsx:41
: (warn) Calls to 'console.log' are not allowed.app/components/jsonDisplay/tree.tsx:21
: (warn) Calls to 'console.log' are not allowed.app/components/TalkOutLoud.tsx:9
: (warn) Calls to 'console.log' are not allowed.app/components/TreeParseGUI.tsx:43
: (warn) Calls to 'console.log' are not allowed.app/components/TreeParseGUI.tsx:44
: (warn) Calls to 'console.log' are not allowed.app/components/TreeParseGUI.tsx:67
: (warn) Calls to 'console.log' are not allowed.app/components/TreeParseGUI.tsx:81
: (warn) Calls to 'console.log' are not allowed.app/components/TreeParseGUI.tsx:102
: (warn) Calls to 'console.log' are not allowed.server.ts:24
: (warn) Calls to 'console.log' are not allowed.server.ts:43
: (warn) Calls to 'console.log' are not allowed.server.ts:63
: (warn) Calls to 'console.log' are not allowed.server.ts:74
: (warn) Calls to 'console.log' are not allowed.server.ts:79
: (warn) Calls to 'console.error' are not allowed.no-floating-promises
app/components/codeSubmission/ParserInput.tsx:25
: (error) Promises must be handled appropriatelyapp/components/codeSubmission/ParserInput.tsx:29
: (error) Promises must be handled appropriatelyapp/components/TreeParseGUI.tsx:40
: (error) Promises must be handled appropriatelyapp/components/TreeParseGUI.tsx:69
: (error) Promises must be handled appropriatelyno-implicit-dependencies
app/TreeParseGUIState.ts:1
: (error) Module '@atomist/tree-path' is not listed as dependency in package.jsonserver.ts:9
: (error) Module '@atomist/tree-path' is not listed as dependency in package.jsonserver.ts:11
: (error) Module 'json-stringify-safe' is not listed as dependency in package.jsonno-import-side-effect
app/components/codeSubmission/codeDisplay.tsx:2
: (error) import with explicit side-effectapp/components/codeSubmission/codeDisplay.tsx:3
: (error) import with explicit side-effectapp/components/codeSubmission/codeDisplay.tsx:4
: (error) import with explicit side-effectapp/components/codeSubmission/codeDisplay.tsx:5
: (error) import with explicit side-effectapp/components/codeSubmission/codeDisplay.tsx:6
: (error) import with explicit side-effectno-null-keyword
app/components/codeSubmission/codeDisplay.tsx:50
: (warn) Use 'undefined' instead of 'null'app/components/codeSubmission/codeDisplay.tsx:88
: (warn) Use 'undefined' instead of 'null'app/components/codeSubmission/codeDisplay.tsx:97
: (warn) Use 'undefined' instead of 'null'app/components/codeSubmission/codeDisplay.tsx:105
: (warn) Use 'undefined' instead of 'null'app/components/codeSubmission/highlightCode.ts:44
: (warn) Use 'undefined' instead of 'null'only-arrow-functions
server.ts:23
: (error) non-arrow functions are forbiddentypedef
app/components/codeSubmission/codeDisplay.tsx:19
: (warn) expected parameter: 'props' to have a typedefapp/components/codeSubmission/codeDisplay.tsx:27
: (warn) expected member-variable-declaration: 'newCode' to have a typedefapp/components/codeSubmission/codeDisplay.tsx:32
: (warn) expected call-signature: 'hasRange' to have a typedefapp/components/codeSubmission/codeDisplay.tsx:32
: (warn) expected parameter: 'ranges' to have a typedefapp/components/codeSubmission/codeDisplay.tsx:38
: (warn) expected call-signature: 'render' to have a typedefapp/components/codeSubmission/highlightCode.ts:15
: (warn) expected call-signature: 'highlightFromAst' to have a typedefapp/components/codeSubmission/ParserInput.tsx:20
: (warn) expected parameter: 'props' to have a typedefapp/components/codeSubmission/ParserInput.tsx:28
: (warn) expected member-variable-declaration: 'event' to have a typedefapp/components/codeSubmission/ParserInput.tsx:28
: (warn) expected member-variable-declaration: 'parserChoice' to have a typedefapp/components/codeSubmission/ParserInput.tsx:40
: (warn) expected member-variable-declaration: 'event' to have a typedefapp/components/codeSubmission/ParserInput.tsx:45
: (warn) expected call-signature: 'radioInputs' to have a typedefapp/components/codeSubmission/ParserInput.tsx:45
: (warn) expected parameter: 'name' to have a typedefapp/components/codeSubmission/ParserInput.tsx:45
: (warn) expected parameter: 'valueAndLabelses' to have a typedefapp/components/codeSubmission/ParserInput.tsx:57
: (warn) expected call-signature: 'render' to have a typedefapp/components/ErrorDisplay.tsx:4
: (warn) expected call-signature: 'ErrorDisplay' to have a typedefapp/components/jsonDisplay/tree.tsx:6
: (warn) expected parameter: 'props' to have a typedefapp/components/jsonDisplay/tree.tsx:14
: (warn) expected call-signature: 'render' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:12
: (warn) expected call-signature: 'effectiveTreeChoice' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:47
: (warn) expected call-signature: 'TreeChoice' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:69
: (warn) expected call-signature: 'disableUnavailable' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:76
: (warn) expected call-signature: 'radioInputs' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:76
: (warn) expected parameter: 'name' to have a typedefapp/components/jsonDisplay/TreeChoice.tsx:76
: (warn) expected parameter: 'valueAndLabelses' to have a typedefapp/components/PathExpressionInput.tsx:4
: (warn) expected call-signature: 'PathExpressionInput' to have a typedefapp/components/TalkOutLoud.tsx:7
: (warn) expected call-signature: 'TalkOutLoud' to have a typedefapp/components/TreeParseGUI.tsx:19
: (warn) expected parameter: 'props' to have a typedefapp/components/TreeParseGUI.tsx:39
: (warn) expected call-signature: 'componentDidMount' to have a typedefapp/components/TreeParseGUI.tsx:51
: (warn) expected member-variable-declaration: 'updateTree' to have a typedefapp/components/TreeParseGUI.tsx:79
: (warn) expected member-variable-declaration: 'words' to have a typedefapp/components/TreeParseGUI.tsx:79
: (warn) expected member-variable-declaration: 'ranges' to have a typedefapp/components/TreeParseGUI.tsx:84
: (warn) expected member-variable-declaration: 'styles' to have a typedefapp/components/TreeParseGUI.tsx:96
: (warn) expected call-signature: 'render' to have a typedefserver.ts:23
: (warn) expected call-signature to have a typedefserver.ts:23
: (warn) expected parameter: 'exception' to have a typedefserver.ts:104
: (warn) expected call-signature: 'condenseSingleChild' to have a typedef[atomist:code-inspection:atomist/a260p86nh/typescript-version/master=@atomist/atomist-sdm]