search

atomist / automation-client

Automation client for running command and events handlers against the Atomist API.
GNU General Public License v3.0
15 stars 16 forks source link

Test errors with proper-lockfile 3.0.1 #225

Closed cdupuis closed 4 years ago

cdupuis commented 6 years ago

https://travis-ci.org/atomist/automation-client-ts/builds/345171346

ddgenome commented 5 years ago

Can't reproduce

cdupuis commented 4 years ago

Upgrade to latest proper-lockfile.

ipcrm commented 4 years ago

It appears this test failure was due to this breaking change in proper-lockfile: https://github.com/moxystudio/node-proper-lockfile/commit/b1d43e525418d74d6fa7cfa246e6451b3cbdd485 due to the removal of the callback function in the function definition.

This was prior to the 3.0.1 release. I was able to duplicate by taking master @ https://github.com/atomist/automation-client/commit/2e3aee2234f3067fe1d484978f582eb10857a79f, bumping proper-lockfile to 3.0.2, and re-running the test suite.

ipcrm commented 4 years ago

After further review, it looks like the code that requires proper-lockfile can be deprecated.