Code Inspection: Tslint on sdm-mutations - Githubissues

atomist / sdm-core

Event-based implementation of an SDM, which subscribes to Atomist GraphQL

Apache License 2.0

6 stars 3 forks source link

Code Inspection: Tslint on sdm-mutations #225

Closed atomist[bot] closed 4 years ago

atomist[bot] commented 4 years ago

max-line-length

test/machine/yaml/mapGoals.test.ts:140: (warn) Exceeds maximum line length of 150

no-floating-promises

test/internal/signing/goalSigning.test.ts:148: (error) Promises must be handled appropriately

no-implicit-dependencies

lib/internal/signing/goalSigning.ts:34: (error) Module 'apollo-link' is not listed as dependency in package.json

no-unused-expression

test/internal/signing/goalSigning.test.ts:159: (error) unused expression, expected an assignment or function call

[atomist:code-inspection:sdm-mutations=@atomist/atomist-sdm]

atomist[bot] commented 4 years ago

Issue closed because last code inspection problem was fixed by @cdupuis when they pushed c918c31.