atomist / sdm-local

Local software delivery machine support
Apache License 2.0
13 stars 4 forks source link

Do not create log/ directories in every repo #138

Closed jessitron closed 6 years ago

jessitron commented 6 years ago

When the git hook runs, it makes log/sdm-local-local.log in the current (project repo) directory. Other people might use the log directory for something other than transient logs that are not relevant to their project. We should log to somewhere temporary, or ~/.atomist, or something outside the repo please, people won't like this file popping up everywhere

cdupuis commented 6 years ago

Hmm, I can't recreate this.

Steps I tried to reproduce:

Note: I'm not testing with linked node modules. Maybe that is important.

johnsonr commented 6 years ago

I've just reproduced this by a commit. However, I am running linked and haven't yet reinstalled everything this morning.

jessitron commented 6 years ago

Either linked or installed globally, I didn't get a log directory when things went smoothly. When I made a commit in the a repo with git hooks installed but that isn't in ATOMIST_ROOT, I got an empty log directory (and a nasty error to the console, I made a different ticket for that)

I don't know what circumstances trigger it

cdupuis commented 6 years ago

Ok, I’m done with this. I’m going to change the log location to .atomist. That will fix it once and for all.

cdupuis commented 6 years ago

Done.