atomist / sdm-local

Local software delivery machine support
Apache License 2.0
13 stars 4 forks source link

Using `os.hostname()` not working for users #160

Closed ddgenome closed 6 years ago

ddgenome commented 6 years ago

os.hostname() is not working reliably for users. We should use localhost or, if you want to avoid problems with people who do not have localhost configured properly, 127.0.0.1.

cdupuis commented 6 years ago

So, you’re saying os.hostname() doesn’t return the correct host name?

ddgenome commented 6 years ago

It returns a host name that is not resolvable to an IP address.

cdupuis commented 6 years ago

So, do we want localhost or 127.0.0.1? I probably also want to make that configurable in the client.config.json approach.

ddgenome commented 6 years ago

Using the IP address should be safer, if less intuitive.

johnsonr commented 6 years ago

This is in local? There's a strategy interface for this: LocalHostUrlAliaser. The default strategy should pick up some configuration or it should be added on config somewhere

cdupuis commented 6 years ago

Yeah, I'm on it.