Closed ddgenome closed 6 years ago
So, you’re saying os.hostname()
doesn’t return the correct host name?
It returns a host name that is not resolvable to an IP address.
So, do we want localhost or 127.0.0.1? I probably also want to make that configurable in the client.config.json
approach.
Using the IP address should be safer, if less intuitive.
This is in local? There's a strategy interface for this: LocalHostUrlAliaser
. The default strategy should pick up some configuration or it should be added on config somewhere
Yeah, I'm on it.
os.hostname()
is not working reliably for users. We should uselocalhost
or, if you want to avoid problems with people who do not havelocalhost
configured properly,127.0.0.1
.