atomist / sdm-local

Local software delivery machine support
Apache License 2.0
13 stars 4 forks source link

Fix implementation of FileSystemRemoteRepoRef #252

Closed ddgenome closed 5 years ago

ddgenome commented 5 years ago

FileSystemRemoteRepoRef provides a set function for the branch property that sets this.opts.branch. There is a corresponding get function for branch as well. Unfortunately, super/AbstractRemoteRepoRef constructor sets the branch at a time when the opts property of FileSystemRemoteRepoRef has not been set yet, so you get a Cannot set property 'branch' of undefined error. Before, the branch property was not set by the AbstractRemoteRepoRef constructor, so this function/error was not triggered. The implementation of FileSystemRemoteRepoRef should not prohibit the parent class from setting the branch property.