Code Inspection: Tslint on drift-sdm - Githubissues

atomist / sdm-pack-aspect

Uses Atomist Project API to visualize important data about your organization

Apache License 2.0

15 stars 4 forks source link

Code Inspection: Tslint on drift-sdm #172

Closed cdupuis closed 5 years ago

cdupuis commented 5 years ago

max-file-line-count

lib/typings/types.ts:1270: (warn) This file has 1271 lines, which exceeds the maximum of 500 lines allowed. Consider breaking this file up into smaller parts

no-empty-interface

lib/typings/types.ts:1052: (error) An empty interface is equivalent to {}.
lib/typings/types.ts:1173: (error) An empty interface is equivalent to {}.
lib/typings/types.ts:1193: (error) An empty interface is equivalent to {}.
lib/typings/types.ts:1239: (error) An empty interface is equivalent to {}.

no-namespace

lib/typings/types.ts:1032: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1051: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1071: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1095: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1138: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1172: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1192: (error) 'namespace' and 'module' are disallowed
lib/typings/types.ts:1238: (error) 'namespace' and 'module' are disallowed

no-shadowed-variable

lib/typings/types.ts:1044: (error) Shadowed name: 'IngestScmCommit'

[atomist:code-inspection:drift-sdm=@atomist/atomist-sdm]

cdupuis commented 5 years ago

Issue closed because last code inspection problem was fixed by @cdupuis when they pushed 14d5ec4.