Code Inspection: Tslint on sp2 - Githubissues

atomist / sdm-pack-aspect

Uses Atomist Project API to visualize important data about your organization

Apache License 2.0

15 stars 4 forks source link

Code Inspection: Tslint on sp2 #242

Closed cdupuis closed 5 years ago

cdupuis commented 5 years ago

max-file-line-count

lib/routes/api.ts:513: (warn) This file has 514 lines, which exceeds the maximum of 500 lines allowed. Consider breaking this file up into smaller parts

max-line-length

lib/aspect/score/ScoredAspect.ts:126: (warn) Exceeds maximum line length of 150

no-shadowed-variable

lib/aspect/compose/classificationAspect.ts:175: (error) Shadowed name: 'fps'
lib/aspect/compose/classificationAspect.ts:175: (error) Shadowed name: 'p'
lib/aspect/compose/classificationAspect.ts:175: (error) Shadowed name: 'pili'
lib/aspect/score/ScoredAspect.ts:134: (error) Shadowed name: 'p'
lib/aspect/score/ScoredAspect.ts:140: (error) Shadowed name: 'scores'
lib/aspect/score/ScoredAspect.ts:143: (error) Shadowed name: 'scored'
lib/aspect/score/ScoredAspect.ts:144: (error) Shadowed name: 'weightedScore'
lib/routes/web-app/webAppRoutes.ts:125: (error) Shadowed name: 'path'

typedef

test/aspect/common/reviewerAspects.test.ts:231: (warn) expected call-signature: 'extractFingerprints' to have a typedef

[atomist:code-inspection:sp2=@atomist/atomist-sdm]

cdupuis commented 5 years ago

Issue closed because branch sp2 was deleted.

cdupuis commented 5 years ago

Issue closed because branch sp2 was deleted.