search

atomist / sdm-pack-docker

Extension Pack for an Atomist SDM to integrate Docker
Apache License 2.0
0 stars 2 forks source link

//FROM/image/name not working for simple, but valid docker images #51

Closed slimslenderslacks closed 5 years ago

slimslenderslacks commented 5 years ago

Trying to extract a docker image with just a name (no tag, no repo)

FROM nginx

COPY docker/nginx.conf /etc/nginx/nginx.conf
COPY resources/public /usr/share/nginx/html

EXPOSE 8080

like this:

        const imageName: string[] = await astUtils.findValues(
            p, DockerFileParser, "docker/Dockerfile", "//FROM/image/name");

does not currently work.

johnsonr commented 5 years ago

Are you sure you'll looking in the right place for the Dockerfile? Otherwise you will get nothing back.

I upgraded the dockerfile-ast library and added a test and this works.

slimslenderslacks commented 5 years ago

I'll have to upgrade to 2.0 before I can evaluate. Working on that.

slimslenderslacks commented 5 years ago

This is all working with an upgrade to 2.0