Code Inspection: tslint on registration

[atomist-bot]

no-duplicate-imports

• lib/fingerprints/applyFingerprint.ts:32: (error) Multiple imports from '../../fingerprints/index' can be combined into one.
• lib/fingerprints/impact.ts:34: (error) Multiple imports from '../../fingerprints/index' can be combined into one.
• lib/machine/FingerprintSupport.ts:78: (error) Multiple imports from '../../fingerprints/index' can be combined into one.

no-floating-promises

• lib/fingerprints/impact.ts:154: (error) Promises must be handled appropriately
• lib/handlers/events/pushImpactHandler.ts:184: (error) Promises must be handled appropriately

no-null-keyword

• lib/fingerprints/backpack.ts:45: (warn) Use 'undefined' instead of 'null'
• lib/fingerprints/backpack.ts:62: (warn) Use 'undefined' instead of 'null'
• lib/fingerprints/dockerFrom.ts:55: (warn) Use 'undefined' instead of 'null'

no-shadowed-variable

• lib/fingerprints/impact.ts:136: (error) Shadowed name: 'votes'

no-trailing-whitespace

• lib/fingerprints/impact.ts:84: (error) trailing whitespace
• lib/fingerprints/impact.ts:138: (error) trailing whitespace
• lib/fingerprints/impact.ts:141: (error) trailing whitespace
• lib/fingerprints/impact.ts:162: (error) trailing whitespace

one-line

• lib/fingerprints/impact.ts:120: (error) missing whitespace

ordered-imports

• lib/fingerprints/impact.ts:49: (error) Import sources within a group must be alphabetized.
• lib/machine/FingerprintSupport.ts:78: (error) Import sources within a group must be alphabetized.

prefer-const

• lib/fingerprints/impact.ts:140: (error) Identifier 'result' is never reassigned; use 'const' instead of 'let'.

semicolon

• lib/fingerprints/impact.ts:91: (error) Missing semicolon
• lib/fingerprints/impact.ts:95: (error) Missing semicolon
• lib/fingerprints/impact.ts:130: (error) Missing semicolon
• lib/fingerprints/impact.ts:146: (error) Missing semicolon
• lib/fingerprints/impact.ts:151: (error) Missing semicolon
• lib/fingerprints/impact.ts:162: (error) Missing semicolon

trailing-comma

• lib/fingerprints/impact.ts:90: (error) Missing trailing comma
• lib/fingerprints/impact.ts:94: (error) Missing trailing comma
• lib/fingerprints/impact.ts:125: (error) Missing trailing comma
• lib/fingerprints/impact.ts:145: (error) Missing trailing comma
• lib/fingerprints/impact.ts:150: (error) Missing trailing comma
• lib/fingerprints/impact.ts:158: (error) Missing trailing comma

typedef

• lib/fingerprints/applyFingerprint.ts:59: (error) expected call-signature: 'pusher' to have a typedef
• lib/fingerprints/broadcast.ts:34: (error) expected call-signature: 'askAboutBroadcast' to have a typedef
• lib/handlers/commands/broadcast.ts:34: (error) expected call-signature: 'askAboutBroadcast' to have a typedef
• lib/handlers/commands/ignoreVersion.ts:55: (error) expected call-signature: 'ignoreVersion' to have a typedef
• lib/handlers/commands/setLibraryGoal.ts:52: (error) expected call-signature: 'setTeamLibraryGoal' to have a typedef
• lib/handlers/commands/setLibraryGoal.ts:79: (error) expected call-signature: 'chooseTeamLibraryGoal' to have a typedef
• lib/handlers/commands/setLibraryGoal.ts:101: (error) expected call-signature: 'setNewTarget' to have a typedef
• lib/handlers/events/pushImpactHandler.ts:79: (error) expected call-signature: 'renderDiffSnippet' to have a typedef
• lib/support/util.ts:19: (error) expected call-signature: 'footer' to have a typedef

whitespace

• lib/fingerprints/impact.ts:136: (error) missing whitespace
• lib/handlers/events/pushImpactHandler.ts:184: (error) missing whitespace

[atomist:code-inspection:registration=tslint]