Code Inspection: tslint on apply-all

[atomist-bot]

deprecation

• lib/fingerprints/npmDeps.ts:78: (error) ChildProcessResult is deprecated: use
• lib/fingerprints/npmDeps.ts:78: (error) spawnAndWatch is deprecated: use spawnAndLog
• lib/fingerprints/npmDeps.ts:88: (error) SuccessIsReturn0ErrorFinder is deprecated: use

max-line-length

• lib/handlers/commands/updateTarget.ts:125: (warn) Exceeds maximum line length of 150

no-string-literal

• lib/machine/FingerprintSupport.ts:173: (error) object access via string literals is disallowed
• lib/machine/FingerprintSupport.ts:173: (error) object access via string literals is disallowed

no-trailing-whitespace

• lib/machine/FingerprintSupport.ts:180: (error) trailing whitespace

no-unnecessary-callback-wrapper

• lib/machine/FingerprintSupport.ts:229: (error) No need to wrap 'prBody' in another function. Just use it directly.
• test/atomist.config.ts:158: (error) No need to wrap 'renderClojureProjectDiff' in another function. Just use it directly.

trailing-comma

• lib/handlers/commands/updateTarget.ts:154: (error) Missing trailing comma

typedef

• lib/handlers/commands/applyFingerprint.ts:43: (error) expected call-signature: 'pushFingerprint' to have a typedef
• lib/handlers/commands/applyFingerprint.ts:187: (error) expected call-signature: 'compileApplyFingerprintCommand' to have a typedef
• lib/handlers/commands/applyFingerprint.ts:194: (error) expected call-signature: 'compileApplyAllFingerprintsCommand' to have a typedef
• lib/handlers/commands/broadcast.ts:34: (error) expected call-signature: 'askAboutBroadcast' to have a typedef
• lib/handlers/commands/updateTarget.ts:186: (error) expected call-signature: 'setNewTargetFingerprint' to have a typedef
• lib/handlers/events/pushImpactHandler.ts:78: (error) expected call-signature: 'renderDiffSnippet' to have a typedef
• lib/machine/FingerprintSupport.ts:171: (error) expected call-signature: 'author' to have a typedef
• lib/machine/FingerprintSupport.ts:176: (error) expected call-signature: 'oneFingerprint' to have a typedef
• lib/machine/FingerprintSupport.ts:214: (error) expected call-signature: 'applyAll' to have a typedef
• lib/support/util.ts:20: (error) expected call-signature: 'footer' to have a typedef

[atomist:code-inspection:apply-all=tslint]