Closed atomist-bot closed 5 years ago
lib/fingerprints/npmDeps.ts:78
lib/fingerprints/npmDeps.ts:88
lib/machine/FingerprintSupport.ts:234
test/atomist.config.ts:178
lib/handlers/commands/applyFingerprint.ts:44
lib/handlers/commands/applyFingerprint.ts:189
lib/handlers/commands/applyFingerprint.ts:196
lib/handlers/commands/broadcast.ts:37
lib/handlers/commands/updateTarget.ts:187
lib/handlers/events/pushImpactHandler.ts:78
lib/machine/FingerprintSupport.ts:184
lib/machine/FingerprintSupport.ts:219
lib/support/util.ts:20
[atomist:code-inspection:updates=tslint]
Issue closed because last code inspection problem was fixed by @atomist-bot when they pushed 69ba72d.
deprecation
lib/fingerprints/npmDeps.ts:78
: (error) ChildProcessResult is deprecated: uselib/fingerprints/npmDeps.ts:78
: (error) spawnAndWatch is deprecated: use spawnAndLoglib/fingerprints/npmDeps.ts:88
: (error) SuccessIsReturn0ErrorFinder is deprecated: useno-unnecessary-callback-wrapper
lib/machine/FingerprintSupport.ts:234
: (error) No need to wrap 'prBody' in another function. Just use it directly.test/atomist.config.ts:178
: (error) No need to wrap 'renderClojureProjectDiff' in another function. Just use it directly.typedef
lib/handlers/commands/applyFingerprint.ts:44
: (error) expected call-signature: 'pushFingerprint' to have a typedeflib/handlers/commands/applyFingerprint.ts:189
: (error) expected call-signature: 'compileApplyFingerprintCommand' to have a typedeflib/handlers/commands/applyFingerprint.ts:196
: (error) expected call-signature: 'compileApplyAllFingerprintsCommand' to have a typedeflib/handlers/commands/broadcast.ts:37
: (error) expected call-signature: 'askAboutBroadcast' to have a typedeflib/handlers/commands/updateTarget.ts:187
: (error) expected call-signature: 'setNewTargetFingerprint' to have a typedeflib/handlers/events/pushImpactHandler.ts:78
: (error) expected call-signature: 'renderDiffSnippet' to have a typedeflib/machine/FingerprintSupport.ts:184
: (error) expected call-signature: 'oneFingerprint' to have a typedeflib/machine/FingerprintSupport.ts:219
: (error) expected call-signature: 'applyAll' to have a typedeflib/support/util.ts:20
: (error) expected call-signature: 'footer' to have a typedef[atomist:code-inspection:updates=tslint]