Code Inspection: tslint on slim/choices - Githubissues

atomist / sdm-pack-fingerprint

Atomist software delivery machine (SDM) extension pack providing fingerprinting support.

Apache License 2.0

1 stars 1 forks source link

Code Inspection: tslint on slim/choices #50

Closed atomist-bot closed 5 years ago

atomist-bot commented 5 years ago

arrow-return-shorthand

lib/handlers/commands/fingerprint.ts:87: (error) This arrow function body can be simplified by omitting the curly braces and the keyword 'return', and wrapping the object literal in parentheses.

no-floating-promises

lib/fingerprints/npmDeps.ts:89: (error) Promises must be handled appropriately

no-shadowed-variable

lib/handlers/commands/fingerprint.ts:75: (error) Shadowed name: 'options'

no-trailing-whitespace

lib/handlers/commands/fingerprint.ts:123: (error) trailing whitespace

ordered-imports

lib/fingerprints/npmDeps.ts:28: (error) Import sources within a group must be alphabetized.

semicolon

lib/handlers/commands/fingerprint.ts:28: (error) Properties should be separated by semicolons
lib/handlers/commands/fingerprint.ts:29: (error) Properties should be separated by semicolons
lib/handlers/commands/fingerprint.ts:63: (error) Missing semicolon
lib/handlers/commands/fingerprint.ts:87: (error) Missing semicolon

trailing-comma

lib/handlers/commands/fingerprint.ts:46: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:50: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:51: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:57: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:61: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:62: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:92: (error) Missing trailing comma
lib/handlers/commands/fingerprint.ts:109: (error) Missing trailing comma

[atomist:code-inspection:slim/choices=tslint]