Code Inspection: Tslint on customingestion

[atomist-bot]

align

• lib/handlers/commands/broadcast.ts:43: (error) parameters are not aligned
• lib/handlers/commands/broadcast.ts:44: (error) parameters are not aligned
• lib/handlers/commands/broadcast.ts:45: (error) parameters are not aligned
• lib/handlers/commands/broadcast.ts:46: (error) parameters are not aligned
• lib/handlers/commands/updateTarget.ts:228: (error) parameters are not aligned
• lib/handlers/commands/updateTarget.ts:229: (error) parameters are not aligned
• lib/machine/fingerprintSupport.ts:488: (error) parameters are not aligned
• lib/machine/fingerprintSupport.ts:489: (error) parameters are not aligned

arrow-parens

• lib/adhoc/preferences.ts:70: (error) Parentheses are prohibited around the parameter in this single parameter arrow function

arrow-return-shorthand

• lib/machine/fingerprintSupport.ts:433: (error) This arrow function body can be simplified by omitting the curly braces and the keyword 'return'.

comment-format

• lib/handlers/commands/fingerprint.ts:45: (error) comment must start with a space
• lib/handlers/commands/fingerprint.ts:50: (error) comment must start with a space
• lib/handlers/commands/fingerprint.ts:54: (error) comment must start with a space

max-line-length

• lib/handlers/commands/broadcast.ts:107: (warn) Exceeds maximum line length of 150
• lib/handlers/commands/updateTarget.ts:95: (warn) Exceeds maximum line length of 150
• lib/machine/fingerprintSupport.ts:286: (warn) Exceeds maximum line length of 150

no-floating-promises

• lib/machine/fingerprintSupport.ts:278: (error) Promises must be handled appropriately
• lib/machine/fingerprintSupport.ts:437: (error) Promises must be handled appropriately

no-return-await

• lib/handlers/commands/updateTarget.ts:202: (error) Unnecessary 'await'.

no-shadowed-variable

• lib/machine/fingerprintSupport.ts:308: (error) Shadowed name: 'votes'
• lib/machine/fingerprintSupport.ts:347: (error) Shadowed name: 'votes'
• lib/machine/fingerprintSupport.ts:407: (error) Shadowed name: 'fps'
• lib/machine/fingerprintSupport.ts:430: (error) Shadowed name: 'votes'
• lib/machine/fingerprintSupport.ts:433: (error) Shadowed name: 'votes'

no-string-literal

• lib/fingerprints/backpack.ts:41: (error) object access via string literals is disallowed

no-trailing-whitespace

• lib/adhoc/preferences.ts:30: (error) trailing whitespace
• lib/adhoc/preferences.ts:45: (error) trailing whitespace
• lib/adhoc/preferences.ts:46: (error) trailing whitespace
• lib/adhoc/preferences.ts:47: (error) trailing whitespace
• lib/handlers/commands/broadcast.ts:153: (error) trailing whitespace
• lib/handlers/commands/fingerprint.ts:54: (error) trailing whitespace
• lib/handlers/commands/updateTarget.ts:222: (error) trailing whitespace
• lib/handlers/commands/updateTarget.ts:223: (error) trailing whitespace
• lib/handlers/commands/updateTarget.ts:224: (error) trailing whitespace
• lib/handlers/commands/updateTarget.ts:225: (error) trailing whitespace

ordered-imports

• lib/adhoc/preferences.ts:26: (error) Import sources within a group must be alphabetized.
• lib/handlers/commands/applyFingerprint.ts:51: (error) Import sources within a group must be alphabetized.
• lib/handlers/commands/applyFingerprint.ts:52: (error) Import sources within a group must be alphabetized.
• lib/handlers/commands/broadcast.ts:40: (error) Import sources within a group must be alphabetized.
• lib/machine/fingerprintSupport.ts:82: (error) Import sources within a group must be alphabetized.
• lib/support/util.ts:18: (error) Import sources within a group must be alphabetized.
• lib/support/util.ts:26: (error) Import sources within a group must be alphabetized.

semicolon

• lib/adhoc/preferences.ts:66: (error) Missing semicolon
• lib/adhoc/preferences.ts:79: (error) Missing semicolon
• lib/handlers/commands/fingerprint.ts:23: (error) Properties should be separated by semicolons
• lib/handlers/commands/updateTarget.ts:94: (error) Missing semicolon
• lib/handlers/commands/updateTarget.ts:141: (error) Missing semicolon
• lib/handlers/commands/updateTarget.ts:151: (error) Missing semicolon
• lib/handlers/commands/updateTarget.ts:207: (error) Missing semicolon
• lib/handlers/commands/updateTarget.ts:214: (error) Missing semicolon
• lib/machine/fingerprintSupport.ts:275: (error) Missing semicolon
• lib/machine/fingerprintSupport.ts:284: (error) Properties should be separated by semicolons
• lib/machine/fingerprintSupport.ts:284: (error) Missing semicolon
• lib/machine/fingerprintSupport.ts:284: (error) Unnecessary semicolon
• lib/machine/fingerprintSupport.ts:416: (error) Missing semicolon
• lib/machine/fingerprintSupport.ts:420: (error) Missing semicolon
• lib/machine/fingerprintSupport.ts:436: (error) Missing semicolon

trailing-comma

• lib/adhoc/fingerprints.ts:48: (error) Missing trailing comma
• lib/adhoc/preferences.ts:37: (error) Missing trailing comma
• lib/adhoc/preferences.ts:38: (error) Missing trailing comma
• lib/adhoc/preferences.ts:63: (error) Missing trailing comma
• lib/adhoc/preferences.ts:64: (error) Missing trailing comma
• lib/adhoc/preferences.ts:75: (error) Missing trailing comma
• lib/adhoc/preferences.ts:76: (error) Missing trailing comma
• lib/adhoc/preferences.ts:77: (error) Missing trailing comma
• lib/handlers/commands/applyFingerprint.ts:271: (error) Missing trailing comma
• lib/handlers/commands/applyFingerprint.ts:272: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:69: (error) Unnecessary trailing comma
• lib/handlers/commands/updateTarget.ts:92: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:93: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:138: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:139: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:140: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:164: (error) Unnecessary trailing comma
• lib/handlers/commands/updateTarget.ts:192: (error) Unnecessary trailing comma
• lib/handlers/commands/updateTarget.ts:206: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:213: (error) Missing trailing comma
• lib/handlers/commands/updateTarget.ts:271: (error) Unnecessary trailing comma
• lib/machine/fingerprintSupport.ts:297: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:298: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:316: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:328: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:329: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:339: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:364: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:365: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:376: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:380: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:404: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:405: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:419: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:427: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:431: (error) Missing trailing comma
• lib/machine/fingerprintSupport.ts:434: (error) Missing trailing comma

triple-equals

• lib/machine/fingerprintSupport.ts:301: (error) != should be !==

typedef

• lib/machine/fingerprintSupport.ts:347: (error) expected call-signature: 'tallyVotes' to have a typedef

[atomist:code-inspection:customingestion=@atomist/atomist-sdm]