search

atomist / sdm-pack-fingerprint

Atomist software delivery machine (SDM) extension pack providing fingerprinting support.
Apache License 2.0
1 stars 1 forks source link

The bot merged a PR before it was approved #76

Closed slimslenderslacks closed 5 years ago

slimslenderslacks commented 5 years ago

Issue moved from atomisthq/automation-api#748

Created by @kipz at 2019-06-12T08:45:04Z:

Comment by @cdupuis at 2019-06-12T08:50:16Z:

Do you have more information on that?

Comment by @kipz at 2019-06-12T08:51:22Z:

This is my original PR: https://github.com/atomisthq/automation-api/pull/745

It could be that https://github.com/atomisthq/automation-api/pull/746 somehow grabbed those commits, merged them and github is being smart about the other PR?

Comment by @kipz at 2019-06-12T08:54:05Z:

We currently suspect that the fingerprint workflow is doing something crazy...

Comment by @slimslenderslacks at 2019-06-12T15:53:38Z:

  1. master -> branch (with changes)
  2. apply fingerprint to branch
  3. master -> branch -> branch1(merge to "master" instead of merge to "branch")
  4. BuildAware autoApprove CodeTransform approves
  5. All changes from branch and branch1 end up in master

Fix is to have PR raised against branch, instead of master

oops

Comment by @slimslenderslacks at 2019-06-12T15:54:25Z:

move to fingerprint pack

slimslenderslacks commented 5 years ago

@kipz found this issue with the missing branch parameter.