atomist / sdm-pack-k8s

Extension Pack for an Atomist SDM to integrate Kubernetes deployments
Apache License 2.0
3 stars 2 forks source link

An ingress with no rules must be deleted #26

Closed ddgenome closed 5 years ago

ddgenome commented 5 years ago

Currently, when the last rule is removed, we attempt to patch the ingress to have an empty list of rules. Kubernetes does not allow an ingress with no rules, so this fails, the ingress is not updated, and the last path remains. I suppose the right thing to do is to delete the ingress if it has no rules, which makes me kind of sad.