search

atomist / sdm-pack-k8s

Extension Pack for an Atomist SDM to integrate Kubernetes deployments
Apache License 2.0
3 stars 2 forks source link

Use most specific information in goal labels #49

Closed ddgenome closed 4 years ago

ddgenome commented 5 years ago

Currently the default set of goal labels uses the the fulfillment name if it is available and defaults to the environment if it is not. For teams that use a single cluster and separate environments by namespace, the environment potentially contains more detailed information while the fulfillment name will likely be the same for the various deploy goals. This leads to multiple goals having the same description, which is confusing.

I'm currently not sure how, but try to make sure to use the "most-specific" cluster/target information in the goal descriptions.

ddgenome commented 5 years ago

Here is the code that determines what the "target" is: https://github.com/atomist/sdm-pack-k8s/blob/fc6f3734e1f5098c720de7eb222d63cda6afb69d/lib/deploy/cluster.ts#L22-L61

We'll have to make sure the environment passed in is not the sanitized one that is restricted to the SDM environment enum.

ddgenome commented 4 years ago

This was addressed in 949b5836c611f888e8664fc69e5b833354bd36e1