search

atomita / fluent-plugin-aws-elasticsearch-service

This repository is extends of https://github.com/uken/fluent-plugin-elasticsearch/ which made connectable to Amazon Elassticsearch Service using Aws Signers V4. Please check the requirements to connect to Amazon Elassticsearch Service without using Aws Signers V4 for before starting use. (reference https://groups.google.com/forum/#!msg/fluentd/uW87VAOqxeE/cfhenicEBAAJ)
MIT License
122 stars 49 forks source link

Move faraday_middleware-aws-sigv4 to major v0.3.0 #61

Closed Evan-S closed 4 years ago

Evan-S commented 4 years ago

This is working fine with v0.3.0. Without it, the dependency chain is broken and requires a manual fix on each install.

I think this is what is happening: fluent-plugin-aws-elasticsearch-service -> fluent-plugin-elasticsearch -> elasticsearch-transport -> elasticsearch-transport (requres faraday (>= 0)) -> faraday (some version higher than 0.15)

Then the faraday_middleware-aws-sigv4 version installed by this project (>= 0.2.4, < 0.3.0) is expecting a faraday below v0.15 resulting in the error in this issue: #59

For every image I'm using this project in, I'm having to run a manual update gem update faraday_middleware-aws-sigv4

The only difference between faraday_middleware-aws-sigv4 v0.2.5 and v0.3.0 is added support for faraday >= 0.15. So, there are no compatibility issues.

cosmo0920 commented 4 years ago

@atomita Could you release the new version with this change?

atomita commented 4 years ago

@Evan-S I just released it. Thank you for PR!