AWS_CONTAINER_CREDENTIALS_RELATIVE_URI uses environment variables

atomita / fluent-plugin-aws-elasticsearch-service

This repository is extends of https://github.com/uken/fluent-plugin-elasticsearch/ which made connectable to Amazon Elassticsearch Service using Aws Signers V4. Please check the requirements to connect to Amazon Elassticsearch Service without using Aws Signers V4 for before starting use. (reference https://groups.google.com/forum/#!msg/fluentd/uW87VAOqxeE/cfhenicEBAAJ)

MIT License

122 stars 49 forks source link

AWS_CONTAINER_CREDENTIALS_RELATIVE_URI uses environment variables #64

Closed happysiro closed 4 years ago

happysiro commented 4 years ago

Hello. I use ECS.

Instead of writing the contents of the environment variable AWS CONTAINER CREDENTIALS RELATIVE URI to a configuration file, you may want to use it directly. What do you think?

happysiro commented 4 years ago

Why is this change really needed?

When using Fargate with ECS, there is no way to know the AWS_CONTAINER_CREDENTIALS_RELATIVE_URI. So suggested this pull request.

cosmo0920 commented 4 years ago

I think that this change breaks compatibility. How about coexisting with config_param like as? https://github.com/atomita/fluent-plugin-aws-elasticsearch-service/pull/64#discussion_r390808287

happysiro commented 4 years ago

Thank you for a good suggestion. Please wait a moment while I correct it.

happysiro commented 4 years ago

I'm late. I revised it, so please review it.

@cosmo0920

cosmo0920 commented 4 years ago

@atomita Could you release a new version which includes this change?