search

atomius0 / Godot-3.1-FXAA-Shader

FXAA Shader for Godot 3.1 GLES2 renderer
12 stars 3 forks source link

Not working in GLES3 #2

Open marcosjouron opened 5 years ago

marcosjouron commented 5 years ago

Hi @atomius0: Your FXAA implementation works beautifully in GLES2 / Godot 3.1. I want to use it in GLES3 backend but I'm getting some strange results, mostly in edge pixels. I'd really appreciate if you could take a look at this. Thank you in advance.

marcosjouron commented 5 years ago

Hi again @atomius0, I really don't want to bother you but i really like to use you shader for one project that ii'm working. As i told you your shader works like a charm in GLES2 but no in GLES3. I was taking a look what could be worng but i'm honestly not very specialized in this stuff and i'cant get any result. Maybe tweaking the right parameters... anyway thanks in advance. BTW: I'm following you in itch.io good job with the 3DPONG

atomius0 commented 5 years ago

Hi, I only ported the shader code from this one (because Godot 3 doesn't have any AA for GLES2 built in): https://godotengine.org/qa/13916/fxaa-broken-in-godot-2-1-2 which was converted from Godot 2.x's source. So it was probably never tested with GLES3, and I don't understand the algorithm well enough to fix it. (or maybe there's a bug in the GLES3 renderer that causes these problems?) Why don't you use Godot 3's native MSAA for GLES3 instead?

marcosjouron commented 5 years ago

MSAA is very expensive for our systems. Any way @atomius0 thanks a lot for your answer. ;)

rico345100 commented 4 years ago

So... no plan to support GLES3? I have no idea why Godot 3 abandoned this fantastic AA solution. MSAA is working but it's really heavy.

Calinou commented 4 years ago

@rico345100 For the record, FXAA has been re-added to the master branch (which uses Vulkan).

I have no idea why Godot 3 abandoned this fantastic AA solution. MSAA is working but it's really heavy.

FXAA tends to have bad press among PC gamers, which is why people didn't rush to implement it in Godot 3.x :slightly_smiling_face:

It looks fine at 1440p and above, but using it for 1080p gaming is hit-and-miss.