search

atomizer / muledump

all your mules are belong to you
84 stars 144 forks source link

Add Toxic Sewers, Mad Lab, and The Hive codes to pcstats.js #138

Closed WesTyler closed 5 years ago

Nightfirecat commented 7 years ago

Add the trailing commas back please?

Otherwise, LGTM. :+1:

WesTyler commented 7 years ago

While we're here, do you know of any source of truth on these "id"s? I just happened to notice this was the Sewers code after running a couple of them. I dug around a bit and couldn't find where these are coming from, or I would add some more in.

Nightfirecat commented 7 years ago

I can honestly say I don't have the faintest idea. To my knowledge, most of the "inner workings" of Muledump come from getting copies of server content/config, which I'm not fully aware how it's obtained. I know it's fairly regularly scraped and hosted here if you want to go digging: http://static.drips.pw/rotmg/

WesTyler commented 7 years ago

Yeah, that's where I was digging earlier. Found some neat stuff, but not what I was looking for :P . Thanks though!

tischepe commented 7 years ago

I don't think Sewer should be added to shortdungeonnames since as far as I know it is not necessary for the tunnel rat fame bonus. Maybe shortdungeonname should be renamed to reflect its purpose.

tischepe commented 7 years ago

@Nightfirecat An older/partial version of the code used to generate http://static.drips.pw/rotmg/ can be found here: https://gist.github.com/atomizer/6705319

WesTyler commented 7 years ago

Maybe shortdungeonname should be renamed to reflect its purpose.

Yeah, I didn't know what that was used for. I'll remove that from this PR :)

WesTyler commented 7 years ago

@atomizer are you still maintaining this project, or should somebody fork?