search

atomizer / muledump

all your mules are belong to you
84 stars 144 forks source link

enabled viewing of dead characters #24

Closed ghost closed 11 years ago

ghost commented 11 years ago

Added a way to view dead characters, also disabled vaults on dead characters

Nightfirecat commented 11 years ago

Looks good, but it doesn't seem to handle errors well. If a character is created, then deleted rather than being killed, the response will look something like this:

Traceback (most recent call last):
File "/base/data/home/runtimes/python/python_lib/versions/1/google/appengine/ext/webapp/_webapp25.py", line 714, in __call__ handler.get(*groups)
File "/base/data/home/apps/realmofthemadgod/release-16-201308271421-1c65d74.369807916521050661/handlerCommon.py", line 6, in get self.handleInternal()
File "/base/data/home/apps/realmofthemadgod/release-16-201308271421-1c65d74.369807916521050661/handlerCommon.py", line 14, in handleInternal (code, message) = self.handle()
File "/base/data/home/apps/realmofthemadgod/release-16-201308271421-1c65d74.369807916521050661/charHandler.py", line 125, in handle return charData.fameChar(accountId, charId)
File "/base/data/home/apps/realmofthemadgod/release-16-201308271421-1c65d74.369807916521050661/charData.py", line 843, in fameChar return (200, fameData.fameToXML(account, char))
File "/base/data/home/apps/realmofthemadgod/release-16-201308271421-1c65d74.369807916521050661/fameData.py", line 179, in fameToXML fameStr += '<BaseFame>%d</BaseFame>' % char.fame.baseFame
AttributeError: 'NoneType' object has no attribute 'baseFame'

Upon receiving this response, it'll be left as a waiting request, and muledump won't update the number of waiting requests because of it. (meaning that you'll have 1+ waiting requests after it stops querying, depending on how many errors it encounters) Otherwise, looks good.