atomizer / muledump

all your mules are belong to you
84 stars 144 forks source link

Consumable named sorting #83

Closed Nightfirecat closed 8 years ago

Nightfirecat commented 8 years ago

Because items change IDs fairly frequently when swaths of items are reassigned positions in the game's XML definitions, or when new items are introduced, sorting them based on their current ID is a fairly fragile strategy which is in no way future-proof.

Instead, given that the item names and their associated tiers are known and well-defined, we can instead sort using the item name as the switch case.

This addresses #80 (comment).

atomizer commented 8 years ago

Makes sense.

I need to learn how to write super-descriptive commit messages like yours.

Nightfirecat commented 8 years ago

Voilà! How to Write a Git Commit Message.