atomone-hub / atomone

AtomOne chain software
Apache License 2.0
14 stars 5 forks source link

chore: make build-ledger, fix reproducible builds, reinforce go version #24

Closed tbruyelle closed 1 month ago

tbruyelle commented 1 month ago
tbruyelle commented 1 month ago

we are enforcing even the subversion while technically that would not be needed if not for consistency of hashes for reproducible builds.

I am not against it, but it's a little tighter as a requirement than what we actually need.

True, but I have found this to be the easiest way to ensure reproducible builds for most users.

If we remove the subversion check, and just check the major version, how do we know about reproducible builds? We could print a warning, but that would be a 4 line warning with all the instructions, it looks a bit annoying to have that for every build, so I chose the current solution.

Let me know if you think of another way.

tbruyelle commented 1 month ago

@giunatale see d13bc86