search

atomontage / xterm-color

ANSI & xterm-256 color text property translator for Emacs
BSD 2-Clause "Simplified" License
219 stars 20 forks source link

Suggested Patch #1

Closed ErikKnowles closed 11 years ago

ErikKnowles commented 11 years ago

Hello and thank you for the great unit. I love having 256 color support in Emacs shells.

OK, onto my patch suggestion: With other terminals I've been using the 90-99 high intensity foreground text color ANSI sequence (c.f., wikipedia's page: http://en.wikipedia.org/wiki/ANSI_escape_code#graphics ). Yeah, it's non-standard, but it seems to be supported in the terminals I use.

I've patched my copy of xterm-color to add the following code directly above the default "...not implemented SGR attribute" bailout for xterm-color--dispatch-csi:

                     ((and (>= init 90)
                           (<= init 97))
                      ;; ANSI FG color
                      (setf (gethash 'foreground-color xterm-color--current)
                            (- init 90))

                      (setq xterm-color--attributes
                            (logior xterm-color--attributes
                                    +xterm-color--bright+))

                      (cdr elems)

                      )

Any interest in adding this patch?

atomontage commented 11 years ago

done