search

atomontage / xterm-color

ANSI & xterm-256 color text property translator for Emacs
BSD 2-Clause "Simplified" License
214 stars 20 forks source link

can this work in compilation mode? #3

Closed blaenk closed 7 years ago

blaenk commented 8 years ago

Does it even make sense to? Not sure, but I found this after looking into enabling ANSI colors in compilation mode (see this).

atomontage commented 8 years ago

I don't see why not, I'll have a look this weekend.

You could also try doing it yourself and making a pull request, shouldn't be hard.

Chris

On Mon, 04 Jan 2016 16:44:15 -0800, Jorge Israel Pe�a notifications@github.com wrote:

Does it even make sense to? Not sure, but I found this after looking into enabling ANSI colors in compilation mode (see this).

Reply to this email directly or view it on GitHub: https://github.com/atomontage/xterm-color/issues/3

blaenk commented 8 years ago

Eh, I just figured I would ask, I'm not demanding or dying for this, I was just wondering if it would even make sense. I'm not too familiar with the technical details of this nor how I would get it working, though I did give it a shot based on the link I mentioned, but that thread seems to do things differently.

atomontage commented 8 years ago

No worries.

If they got ansi-color to work, then I can probably get mine to work with minimal effort too.

I'll have a look at it first chance I get.

On Tue, 05 Jan 2016 17:42:27 -0800, Jorge Israel Pe�a notifications@github.com wrote:

Eh, I just figured I would ask, I'm not demanding or dying for this, I was just wondering if it would even make sense. I'm not too familiar with the technical details of this nor how I would get it working, though I did give it a shot based on the link I mentioned, but that thread seems to do things differently.

Reply to this email directly or view it on GitHub: https://github.com/atomontage/xterm-color/issues/3#issuecomment-169192029

blaenk commented 8 years ago

Sounds great! No rush on my part though!

atomontage commented 7 years ago

I added support for standalone compilation-mode buffers. Look at the updated documentation for the configuration.

For comint-mode buffers that use compilation-shell-minor-mode, the comint configuration in the documentation works fine.

The ansi-color config at the URL you posted (and also here: http://endlessparentheses.com/ansi-colors-in-the-compilation-buffer-output.html) is not optimal, since it processes the incoming bytes in discrete batches via regular expressions, which may lead to corrupted output and other inaccuracies.