search

atomontage / xterm-color

ANSI & xterm-256 color text property translator for Emacs
BSD 2-Clause "Simplified" License
214 stars 20 forks source link

Recent version breaks Python Syntax highlighting #7

Closed cpaulik closed 8 years ago

cpaulik commented 8 years ago

https://github.com/atomontage/xterm-color/commit/81019f45efc191bc393f499855e604672de0531c seems to cause https://github.com/syl20bnr/spacemacs/issues/6501

The spacemacs configuration of xterm-color is 

      (add-hook 'comint-preoutput-filter-functions 'xterm-color-filter)
      (setq comint-output-filter-functions
            (remove 'ansi-color-process-output comint-output-filter-functions))
      (setq font-lock-unfontify-region-function 'xterm-color-unfontify-region)
      (add-hook 'eshell-mode-hook 'spacemacs/init-eshell-xterm-color))))
atomontage commented 8 years ago

This shouldn't be related to font-lock-unfontify-region-function (which is configured as intended, I will see if i can improve it so that it doesn't take effect on every buffer with font-locking on), it's caused by a commit I recently merged that switched font-lock-syntactic-keywords to syntax-propertize-function thinking the 2 are equivalent (they are not).

The current master of xterm-color should fix the problem.

Let me know if it works so I can close the issue.

cpaulik commented 8 years ago

Thank you. It works again now.