Closed ImahnShekhzadeh closed 10 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
a8f614b
) 35.92% compared to head (f8c6d1f
) 35.92%.
Files | Patch % | Lines |
---|---|---|
runner/src/models/cfm_module.py | 20.00% | 4 Missing :warning: |
runner/src/models/components/plotting.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #102
Comment: In the NB
model-comparison-plotting.ipynb
, I left things as they are, since the device is explicitly chosen to be the CPU, i.e. no CPU-GPU overhead exists.PS: @kilianFatras The tensors in the tutorials are also created on the corresponding device now, since I fixed that before you posted your comment :slightly_smiling_face:
Before submitting
pytest
command?pre-commit run -a
command?