atong01 / conditional-flow-matching

TorchCFM: a Conditional Flow Matching library
https://arxiv.org/abs/2302.00482
MIT License
1.27k stars 103 forks source link

fix: put tensors on device during creation #103

Closed ImahnShekhzadeh closed 10 months ago

ImahnShekhzadeh commented 10 months ago

Fixes #102

Comment: In the NB model-comparison-plotting.ipynb, I left things as they are, since the device is explicitly chosen to be the CPU, i.e. no CPU-GPU overhead exists.

PS: @kilianFatras The tensors in the tutorials are also created on the corresponding device now, since I fixed that before you posted your comment :slightly_smiling_face:

Before submitting

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a8f614b) 35.92% compared to head (f8c6d1f) 35.92%.

Files Patch % Lines
runner/src/models/cfm_module.py 20.00% 4 Missing :warning:
runner/src/models/components/plotting.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ======================================= Coverage 35.92% 35.92% ======================================= Files 67 67 Lines 7399 7399 ======================================= Hits 2658 2658 Misses 4741 4741 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.