search

atong01 / conditional-flow-matching

TorchCFM: a Conditional Flow Matching library
https://arxiv.org/abs/2302.00482
MIT License
1.25k stars 101 forks source link

Remove Pytorch Lightning? #121

Closed GeoffStr closed 4 months ago

GeoffStr commented 4 months ago

Hi!

Great repo.

The only difficulty I have is that the pytorch lightning abstractions have made integrating into other projects pretty hard. I tend to think plain pytorch is actually cleaner and easier to understand these days -- as well as much more flexible :)! I would love to build on your work, but I'm a bit stuck with the pytorch lightning induced issues.

Do you have any plans on the roadmap to pull out the pytorch lightning related code? If so, I would be really interested in helping! Thanks!

atong01 commented 4 months ago

Hi!

This is not on my roadmap. Too busy! But I agree with you, it does make things more difficult to reuse. If there are specific things you think would be useful to pull out, happy to consider how to do this.

atong01 commented 4 months ago

Closing for now. If anyone feels like helping on this please feel free to reopen!