search

atong01 / conditional-flow-matching

TorchCFM: a Conditional Flow Matching library
https://arxiv.org/abs/2302.00482
MIT License
1.27k stars 104 forks source link

Unused `num_images` param in cifar10 example #73

Open QB3 opened 1 year ago

QB3 commented 1 year ago

The parameter num_images is currently unused in the cifar10 example https://github.com/atong01/conditional-flow-matching/blob/21cd0c888186f6e2b76deb393800361b8a850e9b/examples/cifar10/train_cifar10.py#L52

It would be great to have a generate_cifar10.py to generate a given number of images, as in the edm code https://github.com/NVlabs/edm

kilianFatras commented 1 year ago

Hello,

Thank you for noticing this unused variable. This will be removed in a future PR.

Regarding the generate_cifar10.py, I agree it is a good idea. I will add it to the to-do list.