Hello @kilianFatras, as discussed in the other PR I have added a test for sigma. I also merged the tests into one function, since a lot of the code was reused across the tests.
I tried the tests with the small fix for sigma, and it catches two errors: for SB-CFM sigma has to be greater than 0, and for TargetConditionalFlowMatcher sigma has to be lower or equal than 1. Maybe we should raise an error at the initialization of these classes if sigma is not in the correct range.
Fixes #\
Before submitting
[x] Did you make sure title is self-explanatory and the description concisely explains the PR?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you test your PR locally with pytest command?
[x] Did you run pre-commit hooks with pre-commit run -a command?
What does this PR do?
Hello @kilianFatras, as discussed in the other PR I have added a test for sigma. I also merged the tests into one function, since a lot of the code was reused across the tests.
I tried the tests with the small fix for sigma, and it catches two errors: for SB-CFM sigma has to be greater than 0, and for
TargetConditionalFlowMatchersigma has to be lower or equal than 1. Maybe we should raise an error at the initialization of these classes if sigma is not in the correct range.Fixes #\
Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃