fix tests sbcfm & tcfm - Githubissues

atong01 / conditional-flow-matching

TorchCFM: a Conditional Flow Matching library

https://arxiv.org/abs/2302.00482

MIT License

1.25k stars 101 forks source link

fix tests sbcfm & tcfm #79

Closed guillaumehu closed 1 year ago

guillaumehu commented 1 year ago

What does this PR do?

Raise a value error if sigma in SB-CFM is zero, and changed the tests accordingly.
fix the tests for TargetCFM and uniformize sigma_t vs sigma.

It now passes all the tests!

Fixes #\

Before submitting

[x] Did you make sure title is self-explanatory and the description concisely explains the PR?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you test your PR locally with pytest command?
[x] Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun? YES

Make sure you had fun coding 🙃

atong01 commented 1 year ago

Looks good, going to make a few more changes but on the main PR.