atoomic / perl-TimeDate

time & date parsing and formatting perl library
http://search.cpan.org/dist/TimeDate/
1 stars 4 forks source link

Small make test bug on leap day in TimeDate-1.20 [rt.cpan.org #75433] #28

Open atoomic opened 4 years ago

atoomic commented 4 years ago

Migrated from rt.cpan.org#75433 (status was 'open')

Requestors:

From ej.lfs@xs4all.nl on 2012-02-29 19:54:28 :

Hi,

I tried running make test today (29 feb 2012) and it failed test 61 in 
t/date.t
Test 61 tries to make sense of this date:
1999 10:02:18 "GMT"
Because today is a leap day, it tries to create a date of 29-02-1999 and 
that date doesn't exist, resulting in a make test failure.
Changing the year to 1996 makes test 61 pass as well.

Bye
Erik-Jan

From oneiros@annoying.org on 2016-02-29 15:02:43 :

On Wed Feb 29 14:54:28 2012, ej.lfs@xs4all.nl wrote:
> Hi,
> 
> I tried running make test today (29 feb 2012) and it failed test 61 in 
> t/date.t
> Test 61 tries to make sense of this date:
> 1999 10:02:18 "GMT"
> Because today is a leap day, it tries to create a date of 29-02-1999 and 
> that date doesn't exist, resulting in a make test failure.
> Changing the year to 1996 makes test 61 pass as well.

Not that anyone else is going to see this problem for another 4 years ... but I've just confirmed the problem, as I ran into myself.

From srezic@cpan.org on 2016-02-29 20:10:17 :

On 2012-02-29 14:54:28, ej.lfs@xs4all.nl wrote:
> Hi,
> 
> I tried running make test today (29 feb 2012) and it failed test 61 in 
> t/date.t
> Test 61 tries to make sense of this date:
> 1999 10:02:18 "GMT"
> Because today is a leap day, it tries to create a date of 29-02-1999 and 
> that date doesn't exist, resulting in a make test failure.
> Changing the year to 1996 makes test 61 pass as well.

See https://rt.cpan.org/Ticket/Display.html?id=112559 which contains a formal patch.