atoomic / perl

a repo to show what could be p7
Other
18 stars 8 forks source link

Jkeenan/math complex t complex 20201010 #300

Closed jkeenan closed 4 years ago

jkeenan commented 4 years ago

This p.r. eliminates the following warnings from cpan/Math-Complex/t/Complex.t:

cpan/Math-Complex/t/Complex .................................... "my" variable $bad masks earlier declaration in same scope at (eval 4) line 3381, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3387, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3393, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3399, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3405, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3411, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3417, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3423, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3429, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3435, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3441, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3447, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3453, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3459, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3465, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3616, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3622, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3628, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3634, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3640, <DATA> line 545.
ok

However, I suspect that using no warnings 'shadow'; for the $z warnings may be sub-optimal. Please review.

Thank you very much. Jim Keenan

jkeenan commented 4 years ago

This p.r. eliminates the following warnings from cpan/Math-Complex/t/Complex.t:

cpan/Math-Complex/t/Complex .................................... "my" variable $bad masks earlier declaration in same scope at (eval 4) line 3381, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3387, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3393, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3399, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3405, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3411, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3417, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3423, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3429, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3435, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3441, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3447, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3453, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3459, <DATA> line 545.
"my" variable $bad masks earlier declaration in same scope at (eval 4) line 3465, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3616, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3622, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3628, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3634, <DATA> line 545.
"my" variable $z masks earlier declaration in same scope at (eval 4) line 3640, <DATA> line 545.
ok

However, I suspect that using no warnings 'shadow'; for the $z warnings may be sub-optimal. Please review.

Thank you very much. Jim Keenan

@atoomic Can you take a look at this p.r.?

Thanks. jimk