search

atoomic / perl

a repo to show what could be p7
Other
18 stars 8 forks source link

cpan/: implement warnings-by-default #303

Closed jkeenan closed 3 years ago

jkeenan commented 4 years ago

In this ticket we will track our progress on implementing Objective 3, warnings-by-default, for tests in the cpan/ directory in the core distribution. See that ticket for guidance on addressing warnings.

On Oct 11 I ran make test on the alpha-dev-03-warnings branch at commit 78482fccd5. I then chopped up the output into individual files, gzipped them, and placed them for your reference in this directory on my server.

By my count, the line count in the output file was 1401, which compares with a line count of 1372 for the same group of files when I run make test on the alpha branch at commit c5c5fb4fb2. So one, somewhat crude way of measuring our progress is how far we manage to reduce the line count in these test runs.

Note that there are at least 2 pending pull requests (https://github.com/atoomic/perl/pull/300; https://github.com/atoomic/perl/pull/302) which pertain to files underneath cpan/. So when these p.r.s are merged, the number of warnings for these files will automatically decrease.

Acceptance Criteria: All tests for this subdirectory PASS; no tests emit warnings.

jkeenan commented 4 years ago

These warnings can be addressed by these p.r.s: https://github.com/atoomic/perl/pull/320 https://github.com/atoomic/perl/pull/300

jkeenan commented 4 years ago

These warnings can be addressed by these p.r.s:

320

300

https://github.com/atoomic/perl/pull/300 has been merged, so that leaves #320 .

jkeenan commented 3 years ago

https://github.com/atoomic/perl/pull/320 has been merged into alpha-dev-03-warnings. The entire cpan/ directory is now consistent with warnings-by-default. Closing this ticket.

Thank you very much. Jim Keenan