search

atoomic / perl

a repo to show what could be p7
Other
18 stars 8 forks source link

220 taint #313

Closed brainbuz closed 4 years ago

brainbuz commented 4 years ago

Isolating my proposed change of strict to getoptlong in a runperl block, also deleted a global stricture at line 16.

jkeenan commented 4 years ago

@brainbuz, Could you revise this pull request so that it just contains changes to t/op/taint.t?

In commit c5e9d4d938, I just now merged into alpha changes for t/op/sprintf2.t, t/op/stash.t, t/op/sub.t-- your p.r. https://github.com/atoomic/perl/pull/312. So changes to those files do not have to be duplicated in this p.r.

Also, a smaller point:

Could I ask that you not put the Issue number a p.r. is referencing in the Subject of a pull request? If your Subject is, as in this case, "220 taint", that renders as "220 taint #313" in the GitHub GUI and as "220 taint (#313)" in my email. Speaking only for myself, I find all those numbers confusing.

Thank you very much. JIm Keenan