search

atoomic / perl

a repo to show what could be p7
Other
18 stars 8 forks source link

cpan/JSON-PP/t/052_object.t: Adapt to warnings-by-default #320

Closed jkeenan closed 3 years ago

jkeenan commented 4 years ago

Quiet two warnings. Correct coding errors that were cause of two others.

jkeenan commented 4 years ago

One alternative approach: Instead of inserting no warnings'bareword; in two subroutine definitions, we could prepend the entire file with:

package JSON::PP::freeze;
1;
package JSON::PP::tojson;
1;

That would correct the problem which was generating warnings. I think that might be preferable.

jkeenan commented 3 years ago

I decided to go ahead with putting two package declarations at the top of cpan/JSON-PP/t/052_object.t. This eliminated the cause of the warnings. I then rebased the branch on alpha-dev-03-warnings and locally merged the branch into the latter. See commit b8e81cf5092241d176873085791a94ea83874a15.

Thank you very much. Jim Keenan