search

atoomic / perl

a repo to show what could be p7
Other
18 stars 8 forks source link

Opbasic cmp #325

Closed brainbuz closed 4 years ago

brainbuz commented 4 years ago

Fix to opbasic/cmp.t for Issue #310.

jkeenan commented 4 years ago

The only change I would request in this pull request is to move the statement no warnings 'uninitialized'; currently found at line 48 of t/opbasic/concat.t down to just before what is currently line 53: ok("$c$alpha$c" eq "foo", "concatenate undef, fore and aft");.

In what is line 49 we know that $alpha and $beta are being initialized, so only $c could be uninitialized. The only place in the block where $c is used is on line 53. So, placing the silencer immediately before line 53 would be the 'narrowest feasible scope` in which to quiet warnings.

brainbuz commented 4 years ago

I will adjust as jim requested and resubmit.

jkeenan commented 4 years ago

I will adjust as jim requested and resubmit.

Note, for a small change like this, you can just make the change in your local branch and push to your repository. The pull request will be updated automatically.