jkeenan
commented
4 years ago I apologize, between my editor and perltidy there ended up being a lot of minor formatting changes in a long file.
I perhaps misled you in a comment in a different commit. We don't generally use perltidy for cleaning up files. "Tidying" in the context of files in the test suite generally means only: "cleaning up a mixture of tabs and spaces in leading whitespace" and "removing trailing whitespace".
And that's only in the context of the test suite. The people who do work on the guts (.c, .h, *.y, etc.) files raise hackles when we tidy up leading whitespace.
We have to bear in mind that at some point our work will (we hope) be merged into what is currently Perl 5 blead. The diff will inevitably be enormous, but we don't want to impose an unnecessary burden on the people who will be reviewing it at that time.
In the case of this file, the number of whitespace changes and line re-breaks overwhelms the relatively few lines of code that address the subject of the ticket. What I would suggest is to return to the file as it exists in alpha-dev-03-warnings, in one commit simply change leading tabs to leading whitespace, then in a second commit perform the actual work needed on the file to get it to run with warnings-by-default.
Thank you very much. Jim Keenan
I apologize, between my editor and perltidy there ended up being a lot of minor formatting changes in a long file.