This will be the first of a series of pull requests embodying work done to bring t/op/*.t into compliance with warnings-by-default (https://github.com/atoomic/perl/issues/309). This file consists of 32 separate commits, most of which touch files in /t/op starting with letters 'a' through 'l'.
There are 2 files in that range that are left out of this p.r.: t/op/caller.t' andt/op/local.t'. See https://github.com/atoomic/perl/issues/339 for a discussion of the former. As for the latter, over the past few days I sought to add descriptions to the many unit tests lacking them. My initial motivation was simply to be able to locate places in the file where warnings were being generated. Then it turned out that the mere act of adding descriptions to tests had bizarre results -- multiplying the number of tests actually being run! I think I have solve that problem, but to keep review of this p.r. manageable, I've not included t/op/local.t.
To evaluate this p.r., try something like the following before-and-after commands.
At HEAD of alpha-dev-03-warnings
TEST_FILES="op/*.t" make test 2>&1 | tee /tmp/alpha-dev-03-warnings.t-op.make-test.output.txt
After applying p.r.
TEST_FILES="op/*.t" make test 2>&1 | tee /tmp/alpha-dev-03-warnings.after-p-r.t-op.make-test.output.txt
This will be the first of a series of pull requests embodying work done to bring
t/op/*.tinto compliance with warnings-by-default (https://github.com/atoomic/perl/issues/309). This file consists of 32 separate commits, most of which touch files in/t/opstarting with letters 'a' through 'l'.There are 2 files in that range that are left out of this p.r.:
t/op/caller.t' andt/op/local.t'. See https://github.com/atoomic/perl/issues/339 for a discussion of the former. As for the latter, over the past few days I sought to add descriptions to the many unit tests lacking them. My initial motivation was simply to be able to locate places in the file where warnings were being generated. Then it turned out that the mere act of adding descriptions to tests had bizarre results -- multiplying the number of tests actually being run! I think I have solve that problem, but to keep review of this p.r. manageable, I've not includedt/op/local.t.To evaluate this p.r., try something like the following before-and-after commands. At HEAD of alpha-dev-03-warnings
After applying p.r.
Thank you very much. Jim Keenan