Closed mstackhouse closed 10 months ago
@elimillera this is ready for review. The primary bug being fixed (#136) has been tested by the issue reporter.
Update DESCRIPTION to note forcats needs to be 1.0.0 or greater because the fct_na_value_to_level isn't present in forcats 0.4.0 (https://forcats.tidyverse.org/news/index.html#forcats-100)
@elimillera updated. Is that the only issue?
Types of changes
A couple of things packed in here:
rlang::call_standardise()
was quite significant. I basically did a static import of the function (and carried the license over) and this works because none of the rlang functions used withincall_standardise()
were internals, and none of the other functions were deprecated. Ideally I could have found a way around it, but the the use of the function was integral tomodify_nested_call()
and the functionality is not at all straightforward to recreate cleanly otherwise.