atorus-research / Tplyr

https://atorus-research.github.io/Tplyr/
Other
95 stars 16 forks source link

Replace ellipsis unpacking with list to `rlang::list2()` #148

Closed mstackhouse closed 8 months ago

mstackhouse commented 10 months ago

In #111 we realized that ellipsis unpacking was broken in some contexts. This had to do with how ellipsis unpacking worked when passing in an object that was being injected. rlang::list2(...) should be equivalent to list(...) except in this type of circumstance.

I took a broad approach of grep'ing the directory to find all these lines - so it could use a cross check to see if I got the right cases. I also put a test in here to make sure the capability worked. I didn't test every single circumstance where this might occur. I think this is ok though because we know all prior functionality is passing, but in that test I verified that injecting a value functions in the desired context.