atorus-research / datasetjson

Read and write CDISC Dataset JSON files
https://atorus-research.github.io/datasetjson/
Apache License 2.0
14 stars 2 forks source link

Don't auto-populate optional attributes with NA #16

Closed mstackhouse closed 1 year ago

mstackhouse commented 1 year ago

As stated by @lexjansen in #3:

Also notice that the fileOID attribute is optional, so there is no need to specify "NA" as a value if the fileOID is not provided to make the Dataset-JSON file compliant. Same is true for several other attributes: asOFDateTime, originator, sourceSystem, sourceSystemVersion.

To be addressed:

file_metadata:

data_metadata:

Additionally, since asOfDateTime is an optional attribute, creationDateTime should be reset to capture write time and not object instantiation.