fileOID is not directly tied to file path, so should not auto-default on write.

[mstackhouse]

Background Information

No response

Definition of Done

No response

[lexjansen]

The issue and code seem to suggest that fileOID has any relation to a file location. This is not the case. From the ODMv2 specification:

"FileOIDs should be universally unique if at all possible. One way to ensure this is to prefix every FileOID with an internet domain name owned by the creator of the ODM file or database (followed by a forward slash, "/"). For example, FileOID="BestPharmaceuticals.com/Study5894/1" might be a good way to denote the first file in a series for study 5894 from Best Pharmaceuticals."

Also notice that the fileOID attribute is optional, so there is no need to specify "NA" as a value if the fileOID is not provided to make the Dataset-JSON file compliant. Same is true for several other attributes: asOFDateTime, originator, sourceSystem, sourceSystemVersion.

[mstackhouse]

Thanks, @lexjansen! Really appreciate these comments. Would love any other feedback you have as well.

[mstackhouse]

• [x] Remove automatic setting of fileOID within write_dataset_json()
• [x] Update documentation to include explanation of the fileOID field description provided by @lexjansen