search

atos1990 / orika

Automatically exported from code.google.com/p/orika
0 stars 0 forks source link

Optional dependency on eclipse project. #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Orika 1.4.0 (trunk now) depends from eclipse project. I suppose that eclipse 
don't needed for main functional bean-to-bean mapping. And It isn't desirable 
include huge and ugly eclipse artifacts in app. I sugest to make this 
dependency  optional аnd delete dependency on orika-eclipse-tools in orika-core

Original issue reported on code.google.com by dkhomya...@gmail.com on 10 Dec 2012 at 1:01

GoogleCodeExporter commented 9 years ago 
These are the dependencies from Orika core pom.xml (no 'eclipse' mentioned 
here...)
    <dependencies>

        <dependency>
            <groupId>org.javassist</groupId>
            <artifactId>javassist</artifactId>
        </dependency>

        <dependency>
            <groupId>com.thoughtworks.paranamer</groupId>
            <artifactId>paranamer</artifactId>
        </dependency>

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-api</artifactId>
        </dependency>

    </dependencies>

were you looking at the new 'tests' module instead?

Original comment by matt.deb...@gmail.com on 11 Dec 2012 at 4:27

GoogleCodeExporter commented 9 years ago 
I've fetched git clone https://github.com/elaatifi/orika.git
I look orika\core\pom.xml
<dependency>
            <groupId>ma.glasnost.orika</groupId>
            <artifactId>orika-eclipse-tools</artifactId>
            <version>${project.parent.version}</version>
            <scope>test</scope>
Then I look
orika\eclipse-tools\pom.xml
<artifactId>org.eclipse.jdt.core</artifactId>

Original comment by dkhomya...@gmail.com on 12 Dec 2012 at 12:03

GoogleCodeExporter commented 9 years ago 
I just updated my local copy. It is all right now. You fixed the problem 
yesterday in 08606997f84e83bc5ee660a354d0cf29e2aa2218 revision. 
Thanks!

Original comment by dkhomya...@gmail.com on 12 Dec 2012 at 12:28

GoogleCodeExporter commented 9 years ago 
Yes, it was always working that way; btw, if 'orika' imports 
'orika-eclipse-tools' at test scope, this makes all of eclipse-tools' 
dependencies come in at test scope as well (via transitive dependency 
resolution). For quite a while, orika has only had those 3 mentioned 
dependencies above at 'compile' scope...

Original comment by matt.deb...@gmail.com on 12 Dec 2012 at 5:38