search

atosatto / ansible-dockerswarm

Docker Engine clustering using "Swarm Mode" and Ansible
https://galaxy.ansible.com/atosatto/docker-swarm/
MIT License
264 stars 148 forks source link

Allow to override Docker and containerd systemd unit #64

Closed atosatto closed 4 years ago

atosatto commented 4 years ago

Alternative implementation to #54 to override the systemd units for the Docker and containerd service.

till commented 4 years ago

@atosatto this works for me, though I would have done two things:

  1. Add # {{ ansible_managed }} into each file (to make it obvious)
  2. Maybe we should have added a test/scenario to confirm this behaviour? So e.g. we can also run it against other Docker versions and easily test and expand on it?
till commented 4 years ago

(Do you want a ticket? I'd send a PR too...) :D

atosatto commented 4 years ago

@till these are both great ideas! Feel free to implement them both in a PR.